[JBPM-9592] External DB driver not working-MySQL #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
force-pushed
the
JBPM-9592
branch
5 times, most recently
from
2221777
to
b6b1108
Compare
afalhambra
approved these changes
Feb 8, 2021
...-soup-dataset-sql/src/main/java/org/dashbuilder/dataprovider/sql/dialect/DefaultDialect.java
Outdated
Show resolved
Hide resolved
Code now does not longer assume that a Date instance is received, but also contemplates LocalDateTime, Number and String cases for completeness
|
Kudos, SonarCloud Quality Gate passed! |
|
Is it possible to add a test? |
We would need the particular mysql instance that now returns LocalDateTime rather than Date, so I would say is not worthy, the change is pretty straightforward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code now does not longer assume that a Date instance is received, but
also contemplates LocalDateTime, Number and String cases for
completeness